Browse Source

fix shellcheck warnings

neilpang 8 years ago
parent
commit
a8c6111197
2 changed files with 6 additions and 4 deletions
  1. 4 4
      dnsapi/dns_lexicon.sh
  2. 2 0
      dnsapi/dns_lua.sh

+ 4 - 4
dnsapi/dns_lexicon.sh

@@ -31,7 +31,7 @@ dns_lexicon_add() {
   export PROVIDER
   export PROVIDER
 
 
   Lx_name=$(echo LEXICON_"${PROVIDER}"_USERNAME | tr '[a-z]' '[A-Z]')
   Lx_name=$(echo LEXICON_"${PROVIDER}"_USERNAME | tr '[a-z]' '[A-Z]')
-  Lx_name_v=$(eval "echo "\$"$Lx_name""")
+  Lx_name_v=$(eval echo \$"$Lx_name")
   _debug "$Lx_name" "$Lx_name_v"
   _debug "$Lx_name" "$Lx_name_v"
   if [ "$Lx_name_v" ]; then
   if [ "$Lx_name_v" ]; then
     _saveaccountconf "$Lx_name" "$Lx_name_v"
     _saveaccountconf "$Lx_name" "$Lx_name_v"
@@ -39,7 +39,7 @@ dns_lexicon_add() {
   fi
   fi
 
 
   Lx_token=$(echo LEXICON_"${PROVIDER}"_TOKEN | tr '[a-z]' '[A-Z]')
   Lx_token=$(echo LEXICON_"${PROVIDER}"_TOKEN | tr '[a-z]' '[A-Z]')
-  Lx_token_v=$(eval "echo "\$"$Lx_token""")
+  Lx_token_v=$(eval echo \$"$Lx_token")
   _debug "$Lx_token" "$Lx_token_v"
   _debug "$Lx_token" "$Lx_token_v"
   if [ "$Lx_token_v" ]; then
   if [ "$Lx_token_v" ]; then
     _saveaccountconf "$Lx_token" "$Lx_token_v"
     _saveaccountconf "$Lx_token" "$Lx_token_v"
@@ -47,7 +47,7 @@ dns_lexicon_add() {
   fi
   fi
 
 
   Lx_password=$(echo LEXICON_"${PROVIDER}"_PASSWORD | tr '[a-z]' '[A-Z]')
   Lx_password=$(echo LEXICON_"${PROVIDER}"_PASSWORD | tr '[a-z]' '[A-Z]')
-  Lx_password_v=$(eval "echo "\$"$Lx_password""")
+  Lx_password_v=$(eval echo \$"$Lx_password")
   _debug "$Lx_password" "$Lx_password_v"
   _debug "$Lx_password" "$Lx_password_v"
   if [ "$Lx_password_v" ]; then
   if [ "$Lx_password_v" ]; then
     _saveaccountconf "$Lx_password" "$Lx_password_v"
     _saveaccountconf "$Lx_password" "$Lx_password_v"
@@ -55,7 +55,7 @@ dns_lexicon_add() {
   fi
   fi
 
 
   Lx_domaintoken=$(echo LEXICON_"${PROVIDER}"_DOMAINTOKEN | tr '[a-z]' '[A-Z]')
   Lx_domaintoken=$(echo LEXICON_"${PROVIDER}"_DOMAINTOKEN | tr '[a-z]' '[A-Z]')
-  Lx_domaintoken_v=$(eval "echo "\$"$Lx_domaintoken""")
+  Lx_domaintoken_v=$(eval echo \$"$Lx_domaintoken")
   _debug "$Lx_domaintoken" "$Lx_domaintoken_v"
   _debug "$Lx_domaintoken" "$Lx_domaintoken_v"
   if [ "$Lx_domaintoken_v" ]; then
   if [ "$Lx_domaintoken_v" ]; then
     eval export "$Lx_domaintoken"
     eval export "$Lx_domaintoken"

+ 2 - 0
dnsapi/dns_lua.sh

@@ -18,6 +18,8 @@ dns_lua_add() {
   txtvalue=$2
   txtvalue=$2
 
 
   if [ -z "$LUA_Key" ] || [ -z "$LUA_Email" ]; then
   if [ -z "$LUA_Key" ] || [ -z "$LUA_Email" ]; then
+    LUA_Key=""
+    LUA_Email=""
     _err "You don't specify luadns api key and email yet."
     _err "You don't specify luadns api key and email yet."
     _err "Please create you key and try again."
     _err "Please create you key and try again."
     return 1
     return 1