neilpang 7 years ago
parent
commit
f823f170e6
1 changed files with 4 additions and 6 deletions
  1. 4 6
      dnsapi/dns_ovh.sh

+ 4 - 6
dnsapi/dns_ovh.sh

@@ -114,8 +114,7 @@ _initAuth() {
 
 
   _info "Checking authentication"
   _info "Checking authentication"
 
 
-  response="$(_ovh_rest GET "domain")"
-  if _contains "$response" "INVALID_CREDENTIAL"; then
+  if ! _ovh_rest GET "domain" || _contains "$response" "INVALID_CREDENTIAL"; then
     _err "The consumer key is invalid: $OVH_CK"
     _err "The consumer key is invalid: $OVH_CK"
     _err "Please retry to create a new one."
     _err "Please retry to create a new one."
     _clearaccountconf OVH_CK
     _clearaccountconf OVH_CK
@@ -150,8 +149,7 @@ dns_ovh_add() {
     if _contains "$response" "$txtvalue"; then
     if _contains "$response" "$txtvalue"; then
       _ovh_rest POST "domain/zone/$_domain/refresh"
       _ovh_rest POST "domain/zone/$_domain/refresh"
       _debug "Refresh:$response"
       _debug "Refresh:$response"
-      _info "Added, sleeping 10 seconds"
-      sleep 10
+      _info "Added"
       return 0
       return 0
     fi
     fi
   fi
   fi
@@ -303,8 +301,8 @@ _ovh_rest() {
     response="$(_get "$_ovh_url")"
     response="$(_get "$_ovh_url")"
   fi
   fi
 
 
-  if [ "$?" != "0" ]; then
-    _err "error $ep"
+  if [ "$?" != "0" ] || _contains "$response" "INVALID_CREDENTIAL"; then
+    _err "error $response"
     return 1
     return 1
   fi
   fi
   _debug2 response "$response"
   _debug2 response "$response"